Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added orbbec camera intrinsic parameters for kinfu demo #2806

Merged
merged 2 commits into from
Jan 21, 2021
Merged

added orbbec camera intrinsic parameters for kinfu demo #2806

merged 2 commits into from
Jan 21, 2021

Conversation

vpisarev
Copy link
Contributor

@vpisarev vpisarev commented Jan 5, 2021

Added intrinsic parameters of Orbbec's Astra camera to Kinfu demo. Probably, this matrix should be put into VideoIO module, OpenNI2 backend, rather than to each individual sample.

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • [N/A] There is reference to original bug report and related work
  • [N/A] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-assigned this Jan 13, 2021
@asmorkalov asmorkalov self-requested a review January 13, 2021 15:37
@asmorkalov
Copy link
Contributor

Looks good for me in general. Please fix trailing whitespace issue: https://build.opencv.org/buildbot/builders/precommit-contrib_docs/builds/14349/steps/whitespace%20opencv_contrib/logs/stdio

@alalek
Copy link
Member

alalek commented Jan 21, 2021

@asmorkalov Ping

@alalek alalek merged commit edc5bb7 into opencv:master Jan 21, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
category: rgbd category: samples feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpisarev @asmorkalov @alalek